Re: [Qemu-devel] [PATCH] target/i386: save EFER for 32-bit targets

2019-06-05 Thread Eduardo Habkost
On Wed, May 29, 2019 at 03:41:56PM +0300, Pavel Dovgalyuk wrote: > i386 (32 bit) emulation uses EFER in wrmsr and in MMU fault > processing. > But it does not included in VMState, because "efer" field is disabled with > #ifdef TARGET_X86_64 > > This patch adds a section for 32-bit targets which sa

Re: [Qemu-devel] [PATCH] target/i386: save EFER for 32-bit targets

2019-05-30 Thread Peter Xu
On Wed, May 29, 2019 at 03:41:56PM +0300, Pavel Dovgalyuk wrote: > +static const VMStateDescription vmstate_efer32 = { > +.name = "cpu/efer32", > +.version_id = 1, > +.minimum_version_id = 1, > + .needed = intel_efer32_needed, Indent might need a touchup. Other than that: Reviewed-

[Qemu-devel] [PATCH] target/i386: save EFER for 32-bit targets

2019-05-29 Thread Pavel Dovgalyuk
i386 (32 bit) emulation uses EFER in wrmsr and in MMU fault processing. But it does not included in VMState, because "efer" field is disabled with #ifdef TARGET_X86_64 This patch adds a section for 32-bit targets which saves EFER when it's value is non-zero. Signed-off-by: Pavel Dovgalyuk --- t