Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-26 Thread Christophe de Dinechin
> On 24 Jun 2019, at 14:38, Alex Bennée wrote: > > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduces a > f

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-25 Thread Eduardo Habkost
On Mon, Jun 24, 2019 at 03:37:24PM +0200, Paolo Bonzini wrote: > On 24/06/19 15:22, Paolo Bonzini wrote: > > On 24/06/19 14:38, Alex Bennée wrote: > >> Commit 2d384d7c8 broken the build when built with: > >> > >> configure --without-default-devices --disable-user > >> > >> The reason was the conv

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Roman Kagan
On Mon, Jun 24, 2019 at 01:38:35PM +0100, Alex Bennée wrote: > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduc

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Paolo Bonzini
On 24/06/19 15:22, Paolo Bonzini wrote: > On 24/06/19 14:38, Alex Bennée wrote: >> Commit 2d384d7c8 broken the build when built with: >> >> configure --without-default-devices --disable-user >> >> The reason was the conversion of cpu->hyperv_synic to >> cpu->hyperv_synic_kvm_only although the res

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Paolo Bonzini
On 24/06/19 14:38, Alex Bennée wrote: > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduces a > feature checking

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Vitaly Kuznetsov
Alex Bennée writes: > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduces a > feature checking mechanism. So I'v

[Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Alex Bennée
Commit 2d384d7c8 broken the build when built with: configure --without-default-devices --disable-user The reason was the conversion of cpu->hyperv_synic to cpu->hyperv_synic_kvm_only although the rest of the patch introduces a feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC