Re: [Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2019-02-12 Thread Paolo Bonzini
On 07/12/18 18:09, Richard Henderson wrote: > This covers inc, dec, and the bit test instructions. > > I believe we've finally covered all of the cases for > which we have an atomic path that would use the cpu_A0 > temp, which is only initialized for address sources. > > Fixes: https://bugs.launc

Re: [Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 6:42 AM, Richard Henderson wrote: > Ping. > > On 12/7/18 5:09 PM, Richard Henderson wrote: >> This covers inc, dec, and the bit test instructions. >> >> I believe we've finally covered all of the cases for >> which we have an atomic path that would use the cpu_A0 >> temp, which is only i

Re: [Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2019-02-05 Thread Richard Henderson
Ping. On 12/7/18 5:09 PM, Richard Henderson wrote: > This covers inc, dec, and the bit test instructions. > > I believe we've finally covered all of the cases for > which we have an atomic path that would use the cpu_A0 > temp, which is only initialized for address sources. > > Fixes: https://bu

Re: [Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2018-12-09 Thread Philippe Mathieu-Daudé
Cc'ing Alberto On 12/7/18 6:09 PM, Richard Henderson wrote: > This covers inc, dec, and the bit test instructions. > > I believe we've finally covered all of the cases for > which we have an atomic path that would use the cpu_A0 > temp, which is only initialized for address sources. > Reported-

[Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2018-12-07 Thread Richard Henderson
This covers inc, dec, and the bit test instructions. I believe we've finally covered all of the cases for which we have an atomic path that would use the cpu_A0 temp, which is only initialized for address sources. Fixes: https://bugs.launchpad.net/qemu/+bug/1803160/comments/4 Signed-off-by: Richa

Re: [Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register destination

2018-11-13 Thread Philippe Mathieu-Daudé
On Tue, Nov 13, 2018 at 8:36 PM Richard Henderson wrote: > > Fixes a TCG crash due to attempting the atomic operation without > having set up the address first. This does not attempt to fix > all of the other missing checks for LOCK. > > Fixes: a7cee522f35 > Fixes: https://bugs.launchpad.net/qemu

[Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register destination

2018-11-13 Thread Richard Henderson
Fixes a TCG crash due to attempting the atomic operation without having set up the address first. This does not attempt to fix all of the other missing checks for LOCK. Fixes: a7cee522f35 Fixes: https://bugs.launchpad.net/qemu/+bug/1803160 Signed-off-by: Richard Henderson --- target/i386/transl