Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2018 at 02:40:33PM -0200, Wainer dos Santos Moschetta wrote: [...] > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > > index f81d35e1f9..2502a3adda 100644 > > > --- a/target/i386/cpu.c > > > +++ b/target/i386/cpu.c > > > @@ -3615,19 +3615,29 @@ static void > > > x86_cpu_

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-11 Thread Wainer dos Santos Moschetta
On 12/10/2018 02:46 PM, Eduardo Habkost wrote: On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as w

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-10 Thread Eduardo Habkost
On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote: > The x86_cpu_class_check_missing_features() returns a list > of unavailable features compared to the host CPU. Currently it may > return empty strings for unamed features as well as duplicated > names. > > For example, t

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-09 Thread Caio Carrara
On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote: > The x86_cpu_class_check_missing_features() returns a list > of unavailable features compared to the host CPU. Currently it may > return empty strings for unamed features as well as duplicated > names. > > For example, t

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-07 Thread Eric Blake
On 12/7/18 4:14 PM, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as well as duplicated s/unamed/unnamed/ names. For example, the qmp "qu

[Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-07 Thread Wainer dos Santos Moschetta
The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as well as duplicated names. For example, the qmp "query-cpu-definitions" below shows one empty string and repeated "mpx" entries: