Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Paolo Bonzini
On 14/06/2017 14:35, Alex Bennée wrote: >> That would cause an unnecessary slowdown in code that runs with >> interrupts disabled but does a lot of indirect jumps... ppc's SLOF >> firmware probably qualifies. > > Really? Yes. :) SLOF basically runs a Forth interpreter. If you run "qemu-syste

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Alex Bennée
Paolo Bonzini writes: > On 14/06/2017 14:14, Alex Bennée wrote: >>> Then Emilio's patch, if a bit of a heavy hammer, is correct. After >>> aa64_daif_write needs you need an exit_tb so that arm_cpu_exec_interrupt >>> is executed again. >> >> This is a case of cpu->interrupt_request being pending

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Paolo Bonzini
On 14/06/2017 14:14, Alex Bennée wrote: >> Then Emilio's patch, if a bit of a heavy hammer, is correct. After >> aa64_daif_write needs you need an exit_tb so that arm_cpu_exec_interrupt >> is executed again. > > This is a case of cpu->interrupt_request being pending but not having > set cpu->ico

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Alex Bennée
Paolo Bonzini writes: > On 14/06/2017 13:45, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> On 14/06/2017 06:48, Richard Henderson wrote: > > Commit e75449a3 ("target/aarch64: optimize indirect branches") causes > a regression by which aarch64 guests freeze under TCG with -sm

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Paolo Bonzini
On 14/06/2017 13:45, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 14/06/2017 06:48, Richard Henderson wrote: Commit e75449a3 ("target/aarch64: optimize indirect branches") causes a regression by which aarch64 guests freeze under TCG with -smp > 1, even with `-accel

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Alex Bennée
Paolo Bonzini writes: > On 14/06/2017 06:48, Richard Henderson wrote: >>> >>> Commit e75449a3 ("target/aarch64: optimize indirect branches") causes >>> a regression by which aarch64 guests freeze under TCG with -smp > 1, >>> even with `-accel accel=tcg,thread=single' (i.e. MTTCG disabled). >>> >

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Paolo Bonzini
On 14/06/2017 06:48, Richard Henderson wrote: >> >> Commit e75449a3 ("target/aarch64: optimize indirect branches") causes >> a regression by which aarch64 guests freeze under TCG with -smp > 1, >> even with `-accel accel=tcg,thread=single' (i.e. MTTCG disabled). >> >> I isolated the problem to th

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-14 Thread Alex Bennée
Emilio G. Cota writes: > The appended fixes it for me. Can you please test? > [ apply with `git am --scissors' ] > > Thanks, > > Emilio > > 8< > > Commit e75449a3 ("target/aarch64: optimize indirect branches") causes > a regression by which aarch64 guests freeze under TCG

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-13 Thread Richard Henderson
On 06/13/2017 03:53 PM, Emilio G. Cota wrote: The appended fixes it for me. Can you please test? [ apply with `git am --scissors' ] Thanks, Emilio 8< Commit e75449a3 ("target/aarch64: optimize indirect branches") causes a regression by which aarch64 guests freeze und

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR Type: series Message-id: 20170613225352

[Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-13 Thread Emilio G. Cota
The appended fixes it for me. Can you please test? [ apply with `git am --scissors' ] Thanks, Emilio 8< Commit e75449a3 ("target/aarch64: optimize indirect branches") causes a regression by which aarch64 guests freeze under TCG with -smp > 1, even with `-accel accel=tc