Re: [Qemu-devel] [PATCH] sysbus: Guard against NULL SysBusDevice::init fn

2013-03-03 Thread Peter Maydell
On 3 March 2013 21:19, Andreas Färber wrote: > Am 03.03.2013 06:30, schrieb Peter Crosthwaite: >> Fix by guarding the call to SysBusDevice::init against a NULL pointer. If no >> pointer is defined return 0 without action. >> >> Signed-off-by: Peter Crosthwaite > > While the patch is correct, I be

Re: [Qemu-devel] [PATCH] sysbus: Guard against NULL SysBusDevice::init fn

2013-03-03 Thread Andreas Färber
Am 03.03.2013 06:30, schrieb Peter Crosthwaite: > In certain cases a device model can init with neither a Device::realize or > SysBusDevice::init (i.e. when its possible to do everything in Object::init). > In this case, the device model should be able to leave both SysBusDevice::init > and Device:

[Qemu-devel] [PATCH] sysbus: Guard against NULL SysBusDevice::init fn

2013-03-02 Thread Peter Crosthwaite
In certain cases a device model can init with neither a Device::realize or SysBusDevice::init (i.e. when its possible to do everything in Object::init). In this case, the device model should be able to leave both SysBusDevice::init and Device::realize as NULL. However what happens in this case in S