Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-22 Thread Avi Kivity
On 06/16/2010 07:58 PM, Glauber Costa wrote: It is, and the fix would be to create the APIC memory slot as sharable across forks (should be easy to fix in the kernel). Kernel pages are already shared across fork, no? What are kernel pages in this context? The APIC access page is a

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-16 Thread Glauber Costa
On Mon, Jun 14, 2010 at 02:58:47PM -0500, Anthony Liguori wrote: > On 06/14/2010 02:42 PM, Glauber Costa wrote: > >On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > >>On 06/14/2010 02:27 PM, Glauber Costa wrote: > >>>This patch fixes a bug that happens with kvm, irqchip-in-kernel,

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-16 Thread Glauber Costa
On Tue, Jun 15, 2010 at 10:33:21AM +0300, Avi Kivity wrote: > On 06/14/2010 10:33 PM, Anthony Liguori wrote: > >On 06/14/2010 02:27 PM, Glauber Costa wrote: > >>This patch fixes a bug that happens with kvm, irqchip-in-kernel, > >>while adding a netdev. Despite the situations of reproduction being >

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-15 Thread Avi Kivity
On 06/15/2010 09:14 AM, Daniel P. Berrange wrote: Hmm, could this problem be hitting other places where we fork() besides the netdev helper script ? I have seen a intermittent bug[1] with migration, where using exec: migration will freeze the entire guest and setting -no-kvm-irqchip fixes the pr

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-15 Thread Avi Kivity
On 06/14/2010 10:42 PM, Glauber Costa wrote: I do agree that this is most likely a kernel bug. But as with any other kernel bugs, I believe this is a easy workaround to have things working even in older kernels until we fix it. That's what -stable is for. We fix it upstream and backport it

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-15 Thread Avi Kivity
On 06/14/2010 10:33 PM, Anthony Liguori wrote: On 06/14/2010 02:27 PM, Glauber Costa wrote: This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. S

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Daniel P. Berrange
On Mon, Jun 14, 2010 at 04:42:37PM -0300, Glauber Costa wrote: > On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > > On 06/14/2010 02:27 PM, Glauber Costa wrote: > > >This patch fixes a bug that happens with kvm, irqchip-in-kernel, > > >while adding a netdev. Despite the situations

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Glauber Costa
On Mon, Jun 14, 2010 at 02:58:47PM -0500, Anthony Liguori wrote: > On 06/14/2010 02:42 PM, Glauber Costa wrote: > >On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > >>On 06/14/2010 02:27 PM, Glauber Costa wrote: > >>>This patch fixes a bug that happens with kvm, irqchip-in-kernel,

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 02:42 PM, Glauber Costa wrote: On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: On 06/14/2010 02:27 PM, Glauber Costa wrote: This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction bei

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Glauber Costa
On Mon, Jun 14, 2010 at 02:33:00PM -0500, Anthony Liguori wrote: > On 06/14/2010 02:27 PM, Glauber Costa wrote: > >This patch fixes a bug that happens with kvm, irqchip-in-kernel, > >while adding a netdev. Despite the situations of reproduction being > >specific to kvm, I believe this fix is pretty

Re: [Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 02:27 PM, Glauber Costa wrote: This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. Specially if we ever want to have our own irqchip

[Qemu-devel] [PATCH] stop cpus before forking.

2010-06-14 Thread Glauber Costa
This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. Specially if we ever want to have our own irqchip in kernel too. The problem happens after the