Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)

2011-07-24 Thread Hans de Goede
Hi, On 07/22/2011 02:40 PM, Gerd Hoffmann wrote: ACK. Another option would be to not call the state callback for the vdagent subtype from spice-server, because like you say it ignores the continued communication between the agent and the server. Then you could remove the subtype check. We can

Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)

2011-07-22 Thread Gerd Hoffmann
ACK. Another option would be to not call the state callback for the vdagent subtype from spice-server, because like you say it ignores the continued communication between the agent and the server. Then you could remove the subtype check. We can even #ifdef the check using SPICE_SERVER_VERSION o

Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)

2011-07-22 Thread Alon Levy
On Fri, Jul 22, 2011 at 11:40:55AM +0200, Hans de Goede wrote: > Define a state callback and make that generate chardev open/close events when > called by the spice-server. Note the code ignores these events for a spicevmc > with a subtypem of vdagent, this subtype specific knowledge is undesirable

[Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3)

2011-07-22 Thread Hans de Goede
Define a state callback and make that generate chardev open/close events when called by the spice-server. Note the code ignores these events for a spicevmc with a subtypem of vdagent, this subtype specific knowledge is undesirable, but unavoidable, see: http://lists.freedesktop.org/archives/spice-d