Re: [Qemu-devel] [PATCH] spice-core: Use g_strdup_printf instead of snprintf

2013-09-02 Thread Christophe Fergeau
On Mon, Sep 02, 2013 at 01:36:19PM +0200, Gerd Hoffmann wrote: > On Mo, 2013-09-02 at 11:53 +0200, Christophe Fergeau wrote: > > Several places in spice-core.c were using either g_malloc+snprintf > > or snprintf+g_strdup to achieve the same result as g_strdup_printf. > > Patch looks good but fails

Re: [Qemu-devel] [PATCH] spice-core: Use g_strdup_printf instead of snprintf

2013-09-02 Thread Gerd Hoffmann
On Mo, 2013-09-02 at 11:53 +0200, Christophe Fergeau wrote: > Several places in spice-core.c were using either g_malloc+snprintf > or snprintf+g_strdup to achieve the same result as g_strdup_printf. Patch looks good but fails checkpatch.pl due to long lines. cheers, Gerd

Re: [Qemu-devel] [PATCH] spice-core: Use g_strdup_printf instead of snprintf

2013-09-02 Thread Marc-André Lureau
ack On Mon, Sep 2, 2013 at 11:53 AM, Christophe Fergeau wrote: > Several places in spice-core.c were using either g_malloc+snprintf > or snprintf+g_strdup to achieve the same result as g_strdup_printf. > > Signed-off-by: Christophe Fergeau > --- > ui/spice-core.c | 22 -- >

[Qemu-devel] [PATCH] spice-core: Use g_strdup_printf instead of snprintf

2013-09-02 Thread Christophe Fergeau
Several places in spice-core.c were using either g_malloc+snprintf or snprintf+g_strdup to achieve the same result as g_strdup_printf. Signed-off-by: Christophe Fergeau --- ui/spice-core.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/ui/spice-core.c