Re: [Qemu-devel] [PATCH] spice: Make logging printing go through QEMU

2018-12-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181211143745.17342-1-cferg...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181211143745.17342-1-cferg...@redhat.com Subject: [Qemu-devel] [PATCH] spice: Make logging printing

Re: [Qemu-devel] [PATCH] spice: Make logging printing go through QEMU

2018-12-11 Thread Daniel P . Berrangé
On Tue, Dec 11, 2018 at 03:37:45PM +0100, Christophe Fergeau wrote: > Since spice 0.14.1, it's possible to use g_log_set_default_handler() to > use a custom function to print spice-server's logs, which gives more > consistent log output. > > With older spice versions, this is not going to work as

[Qemu-devel] [PATCH] spice: Make logging printing go through QEMU

2018-12-11 Thread Christophe Fergeau
Since spice 0.14.1, it's possible to use g_log_set_default_handler() to use a custom function to print spice-server's logs, which gives more consistent log output. With older spice versions, this is not going to work as expected, but will not have any ill effect, so this call is not conditional on