Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-07 Thread Blue Swirl
On 11/6/07, Paul Brook <[EMAIL PROTECTED]> wrote: > > > IIUC enabling/disabling boot mode is no different to and other VM change. > > > If the virtual->physical mapping happens to be the same then it's > > > perfectly ok to reuse the TB. > > > > Not in this case: in boot mode, physical and virtual

Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-06 Thread Robert Reif
This patch also performs a CPU reset after the CPU is registered rather than before. Why is this change needed? Reset should be doing CPU dependent stuff and the CPU dependent setup is performed when the CPU is registered.

Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-06 Thread Paul Brook
> > IIUC enabling/disabling boot mode is no different to and other VM change. > > If the virtual->physical mapping happens to be the same then it's > > perfectly ok to reuse the TB. > > Not in this case: in boot mode, physical and virtual address 0 > generates TBs from PROM code. How is this diffe

Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-06 Thread Blue Swirl
On 11/6/07, Paul Brook <[EMAIL PROTECTED]> wrote: > > > This patch also removes the MMU flags from being saved in the > > > translation block code as a result of an off line discussion with Paul > > > Brook. > > > > I'd like to hear the reasoning behind that. The TBs generated while in > > boot mod

Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-06 Thread Paul Brook
> > This patch also removes the MMU flags from being saved in the > > translation block code as a result of an off line discussion with Paul > > Brook. > > I'd like to hear the reasoning behind that. The TBs generated while in > boot mode and MMU disabled may contain translations generated from > v

Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-06 Thread Blue Swirl
On 11/6/07, Robert Reif <[EMAIL PROTECTED]> wrote: > This patch adds CPU dependent boot mode flag support. > > Different CPUs use different bits for the boot mode flag. The constant > MMU_BM is replaced with a variable which is set for the selected CPU. Nice. I have a patch for OpenBIOS to fix se

[Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-05 Thread Robert Reif
This patch adds CPU dependent boot mode flag support. Different CPUs use different bits for the boot mode flag. The constant MMU_BM is replaced with a variable which is set for the selected CPU. This patch also removes the MMU flags from being saved in the translation block code as a result of