Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 08:02, Benjamin Herrenschmidt wrote: > We were incorrectly g_free'ing an object that isn't allocated > in one error path and failed to release it completely in another > > This fixes qemu crashes with some cases of IO errors. > > Signed-off-by: Benjamin Herrenschmidt Thanks,

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 22:20 +0200, Alexander Graf wrote: > So do you want to resend? I can just fix it on the fly too. If you can then sure, please do :-) Cheers, Ben.

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Alexander Graf
On 19.06.2012, at 22:18, Benjamin Herrenschmidt wrote: > On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: >> Tab alert. :) > > Argh :-) Gotta get an emacs config for use with qemu :-) So do you want to resend? I can just fix it on the fly too. Alex

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Benjamin Herrenschmidt
On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote: > Tab alert. :) Argh :-) Gotta get an emacs config for use with qemu :-) Cheers, Ben.

Re: [Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-19 Thread Andreas Färber
Am 19.06.2012 08:02, schrieb Benjamin Herrenschmidt: > We were incorrectly g_free'ing an object that isn't allocated > in one error path and failed to release it completely in another > > This fixes qemu crashes with some cases of IO errors. > > Signed-off-by: Benjamin Herrenschmidt > --- > hw/

[Qemu-devel] [PATCH] spapr_vscsi: Error handling fixes

2012-06-18 Thread Benjamin Herrenschmidt
We were incorrectly g_free'ing an object that isn't allocated in one error path and failed to release it completely in another This fixes qemu crashes with some cases of IO errors. Signed-off-by: Benjamin Herrenschmidt --- hw/spapr_vscsi.c |4 +++- 1 file changed, 3 insertions(+), 1 deletio