Re: [Qemu-devel] [PATCH] spapr_pci: Improve error message

2019-05-30 Thread David Gibson
On Thu, May 30, 2019 at 09:40:27AM +0200, Greg Kurz wrote: > On Thu, 30 May 2019 10:40:49 +1000 > David Gibson wrote: > > > On Wed, May 29, 2019 at 07:15:09PM +0200, Greg Kurz wrote: > > > Every PHB must have a unique index. This is checked at realize but when > > > a duplicate index is detected,

Re: [Qemu-devel] [PATCH] spapr_pci: Improve error message

2019-05-30 Thread Greg Kurz
On Thu, 30 May 2019 10:40:49 +1000 David Gibson wrote: > On Wed, May 29, 2019 at 07:15:09PM +0200, Greg Kurz wrote: > > Every PHB must have a unique index. This is checked at realize but when > > a duplicate index is detected, an error message mentioning BUIDs is > > printed. This doesn't help mu

Re: [Qemu-devel] [PATCH] spapr_pci: Improve error message

2019-05-29 Thread David Gibson
On Wed, May 29, 2019 at 07:15:09PM +0200, Greg Kurz wrote: > Every PHB must have a unique index. This is checked at realize but when > a duplicate index is detected, an error message mentioning BUIDs is > printed. This doesn't help much, especially since BUID is an internal > concept that is no lon

[Qemu-devel] [PATCH] spapr_pci: Improve error message

2019-05-29 Thread Greg Kurz
Every PHB must have a unique index. This is checked at realize but when a duplicate index is detected, an error message mentioning BUIDs is printed. This doesn't help much, especially since BUID is an internal concept that is no longer exposed to the user. Fix the message to mention the index prop