Re: [Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

2019-09-09 Thread David Gibson
On Mon, Sep 09, 2019 at 08:10:09PM +0200, Greg Kurz wrote: > Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL > tpm_proxy->host_path pointer to open(). This is based on the fact that > h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes > tpm_proxy to tpm_e

Re: [Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

2019-09-09 Thread Michael Roth
Quoting Greg Kurz (2019-09-09 13:10:09) > Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL > tpm_proxy->host_path pointer to open(). This is based on the fact that > h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes > tpm_proxy to tpm_execute(). > > The

[Qemu-devel] [PATCH] spapr-tpm-proxy: Drop misleading check

2019-09-09 Thread Greg Kurz
Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL tpm_proxy->host_path pointer to open(). This is based on the fact that h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes tpm_proxy to tpm_execute(). The check in h_tpm_comm() is abusive actually since a sp