Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/06/2013 04:22 PM, Alexander Graf wrote: > > > Am 06.09.2013 um 07:04 schrieb Alexey Kardashevskiy : > >> On 09/06/2013 12:24 AM, Alexey Kardashevskiy wrote: >>> On 09/05/2013 11:08 PM, Alexander Graf wrote: On 05.09.2013, at 14:49, Alexey Kardashevskiy wrote: > On 09/05/

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
Am 06.09.2013 um 07:04 schrieb Alexey Kardashevskiy : > On 09/06/2013 12:24 AM, Alexey Kardashevskiy wrote: >> On 09/05/2013 11:08 PM, Alexander Graf wrote: >>> >>> On 05.09.2013, at 14:49, Alexey Kardashevskiy wrote: >>> On 09/05/2013 10:16 PM, Alexander Graf wrote: > > On 05.09

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/06/2013 12:24 AM, Alexey Kardashevskiy wrote: > On 09/05/2013 11:08 PM, Alexander Graf wrote: >> >> On 05.09.2013, at 14:49, Alexey Kardashevskiy wrote: >> >>> On 09/05/2013 10:16 PM, Alexander Graf wrote: On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: > On 09/05/2013

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 11:08 PM, Alexander Graf wrote: > > On 05.09.2013, at 14:49, Alexey Kardashevskiy wrote: > >> On 09/05/2013 10:16 PM, Alexander Graf wrote: >>> >>> On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: >>> On 09/05/2013 08:21 PM, Alexander Graf wrote: > > On 05.09.2013,

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 14:49, Alexey Kardashevskiy wrote: > On 09/05/2013 10:16 PM, Alexander Graf wrote: >> >> On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: >> >>> On 09/05/2013 08:21 PM, Alexander Graf wrote: On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: > On 09/

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 10:16 PM, Alexander Graf wrote: > > On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: > >> On 09/05/2013 08:21 PM, Alexander Graf wrote: >>> >>> On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: >>> On 09/05/2013 07:27 PM, Alexander Graf wrote: > > On 05.09.2013,

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: > On 09/05/2013 08:21 PM, Alexander Graf wrote: >> >> On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: >> >>> On 09/05/2013 07:27 PM, Alexander Graf wrote: On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: > On 09/

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 08:21 PM, Alexander Graf wrote: > > On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: > >> On 09/05/2013 07:27 PM, Alexander Graf wrote: >>> >>> On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: >>> On 09/05/2013 05:08 PM, Alexander Graf wrote: > > > Am 05.09.

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: > On 09/05/2013 07:27 PM, Alexander Graf wrote: >> >> On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: >> >>> On 09/05/2013 05:08 PM, Alexander Graf wrote: Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy : >

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 07:27 PM, Alexander Graf wrote: > > On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: > >> On 09/05/2013 05:08 PM, Alexander Graf wrote: >>> >>> >>> Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy : >>> On the real hardware, RTAS is called in real mode and therefore

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: > On 09/05/2013 05:08 PM, Alexander Graf wrote: >> >> >> Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy : >> >>> On the real hardware, RTAS is called in real mode and therefore >>> ignores top 4 bits of the address passed in the call. >

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 05:08 PM, Alexander Graf wrote: > > > Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy : > >> On the real hardware, RTAS is called in real mode and therefore >> ignores top 4 bits of the address passed in the call. > > Shouldn't we ignore the upper 4 bits for every memory acces

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy : > On the real hardware, RTAS is called in real mode and therefore > ignores top 4 bits of the address passed in the call. Shouldn't we ignore the upper 4 bits for every memory access in real mode, not just that one parameter? Alex > > Th

[Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-04 Thread Alexey Kardashevskiy
On the real hardware, RTAS is called in real mode and therefore ignores top 4 bits of the address passed in the call. This fixes QEMU to do the same thing. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_rtas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/sp