Re: [Qemu-devel] [PATCH] spapr: fix core unplug crash

2016-07-10 Thread David Gibson
On Fri, Jul 08, 2016 at 03:12:07PM +0200, Greg Kurz wrote: > If the host has 8 threads/core and the guest is started with: > > -smp cores=1,threads=4,maxcpus=12 > > It is possible to crash QEMU by doing: > > (qemu) device_add host-spapr-cpu-core,core-id=16,id=foo > (qemu) device_del foo > Segmen

[Qemu-devel] [PATCH] spapr: fix core unplug crash

2016-07-08 Thread Greg Kurz
If the host has 8 threads/core and the guest is started with: -smp cores=1,threads=4,maxcpus=12 It is possible to crash QEMU by doing: (qemu) device_add host-spapr-cpu-core,core-id=16,id=foo (qemu) device_del foo Segmentation fault This is caused because spapr_core_unplug() assumes cpu_dt_id ==