Re: [Qemu-devel] [PATCH] spapr: drop useless sanity check in spapr_irq_alloc*()

2018-04-11 Thread David Gibson
On Wed, Apr 11, 2018 at 07:46:06PM +0200, Greg Kurz wrote: > Both spapr_irq_alloc() and spapr_irq_alloc_block() have an errp > parameter, but they don't use it if XICS hasn't been initialized > yet. > > This is doubly wrong: > > - all callers do pass a non-null Error **, ie, they expect an error

[Qemu-devel] [PATCH] spapr: drop useless sanity check in spapr_irq_alloc*()

2018-04-11 Thread Greg Kurz
Both spapr_irq_alloc() and spapr_irq_alloc_block() have an errp parameter, but they don't use it if XICS hasn't been initialized yet. This is doubly wrong: - all callers do pass a non-null Error **, ie, they expect an error to be propagated in case of failure - XICS obviously needs to be initi