Re: [Qemu-devel] [PATCH] spapr: Correct inverted test in spapr_pc_dimm_node()

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 11:52:57 +1000 David Gibson wrote: > This function was introduced between v2.11 and v2.12 to replace obsolete > ways of specifying the NUMA nodes for DIMMs. It's used to find the correct > node for an LMB, by locating which DIMM object it lies within. > > Unfortunately, one

[Qemu-devel] [PATCH] spapr: Correct inverted test in spapr_pc_dimm_node()

2018-07-09 Thread David Gibson
This function was introduced between v2.11 and v2.12 to replace obsolete ways of specifying the NUMA nodes for DIMMs. It's used to find the correct node for an LMB, by locating which DIMM object it lies within. Unfortunately, one of the checks is inverted, so we check whether the address is less