Re: [Qemu-devel] [PATCH] softmmu: fixing usage of cpu_st/ld* from helpers

2014-09-15 Thread Richard Henderson
On 09/15/2014 03:50 AM, Pavel Dovgalyuk wrote: > +/* inline helper ld function */ > + > +static inline DATA_TYPE > +glue(glue(helper_inline_ld, SUFFIX), MEMSUFFIX)(CPUArchState *env, > +target_ulong addr, > +

Re: [Qemu-devel] [PATCH] softmmu: fixing usage of cpu_st/ld* from helpers

2014-09-15 Thread Peter Maydell
CCing RTH who was the last person to do something with this area of the code I think. I thought the correct answer to this problem was "don't use the cpu_st* functions but use something else you can pass GETRA() to" ? On 15 September 2014 03:50, Pavel Dovgalyuk wrote: > MMU helper functions are c

[Qemu-devel] [PATCH] softmmu: fixing usage of cpu_st/ld* from helpers

2014-09-15 Thread Pavel Dovgalyuk
MMU helper functions are called from generated code and other helper functions. In both cases they try to get function's return address for using it while restoring virtual CPU state. When MMU helper is called from some other helper function (like helper_maskmov_xmm) through cpu_st* function, the