Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free

2014-10-28 Thread Stefan Hajnoczi
On Mon, Oct 06, 2014 at 09:33:45AM -0700, Chris Spiegel wrote: > If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is > freed. If "err" is not set to NULL before calling > bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on > error, and will be freed again. > > T

Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free

2014-10-06 Thread Markus Armbruster
Copying stable and maintainers. Chris Spiegel writes: > If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is > freed. If "err" is not set to NULL before calling > bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on > error, and will be freed again. > > This can

[Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free

2014-10-06 Thread Chris Spiegel
If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is freed. If "err" is not set to NULL before calling bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on error, and will be freed again. This can be triggered by starting a VM with at least two drives and then att