On Wed, Dec 21, 2016 at 06:58:44PM +0100, Paolo Bonzini wrote:
> On 21/12/2016 14:59, Igor Mammedov wrote:
> >> Apparently a misunderstanding of the underlying command line handling
> >> mechanics.
> >>
> >>> Also this patch would break build for targets that don't link smbios.c
> >>> (i.e. which d
On 21/12/2016 14:59, Igor Mammedov wrote:
>> Apparently a misunderstanding of the underlying command line handling
>> mechanics.
>>
>>> Also this patch would break build for targets that don't link smbios.c
>>> (i.e. which don't have CONFIG_SMBIOS=y)
>>
>> Ah, I hadn't spotted that - apologies
On Wed, 21 Dec 2016 12:35:09 +
Leif Lindholm wrote:
> On Wed, Dec 21, 2016 at 11:51:02AM +0100, Igor Mammedov wrote:
> > On Fri, 16 Dec 2016 15:23:19 +
> > > Verified on ARM mach-virt with UEFI shell "smbiosview" command and QEMU
> > > command line parameter -smbios type=0,version=fooba
On Wed, Dec 21, 2016 at 11:51:02AM +0100, Igor Mammedov wrote:
> On Fri, 16 Dec 2016 15:23:19 +
> > Verified on ARM mach-virt with UEFI shell "smbiosview" command and QEMU
> > command line parameter -smbios type=0,version=foobar.
> >
> > arch_init.c| 6 +++---
> > include/hw/s
On Fri, 16 Dec 2016 15:23:19 +
Leif Lindholm wrote:
> Commit c30e1565 ("smbios: implement smbios support for mach-virt")
> enabled automatic generation of SMBIOS tables for TARGET_ARM, and
> actually provides data for the "virt" machine.
>
> However, do_smbios_option() still had an #ifdef TA
So, in addition to the style issue I was automatically notified of, I
also neglected to CC the appropriate people - adding them here.
As for the style issue - is it more important to adhere to
checkpatch.pl or to surrounding definitions?
Regards,
Leif
On Fri, Dec 16, 2016 at 03:23:19PM +, L
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for
TARGET_ARM
Message-id: 20161216152319.12494-1-leif.lindh...@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin
Commit c30e1565 ("smbios: implement smbios support for mach-virt")
enabled automatic generation of SMBIOS tables for TARGET_ARM, and
actually provides data for the "virt" machine.
However, do_smbios_option() still had an #ifdef TARGET_I386, preventing
any -smbios command line options from being pa
