Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-17 Thread Jan Kiszka
On 2012-02-16 12:06, Kevin Wolf wrote: > Am 15.02.2012 19:55, schrieb Jan Kiszka: >> On 2012-02-15 19:45, Michael S. Tsirkin wrote: >>> Remove ugly macros for field names, >>> change done by the following script: >>> >>> s#\bifq_prev\b#m_prev#g; >>> s#\bifq_next\b#m_next#g; >>> s#\bifs_prev\b#m_pre

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Michael S. Tsirkin
On Wed, Feb 15, 2012 at 07:55:47PM +0100, Jan Kiszka wrote: > On 2012-02-15 19:45, Michael S. Tsirkin wrote: > > Remove ugly macros for field names, > > change done by the following script: > > > > s#\bifq_prev\b#m_prev#g; > > s#\bifq_next\b#m_next#g; > > s#\bifs_prev\b#m_prevpkt#g; > > s#\bifs_ne

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Kevin Wolf
Am 16.02.2012 12:09, schrieb Peter Maydell: > On 16 February 2012 11:06, Kevin Wolf wrote: >> What are all these m_ and mh_ prefixes for struct fields even about? >> When I have an mbuf, I know perfectly well that it is one, and that >> m_hdr is a header of it. > > That's the dead hand of Sixth E

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Peter Maydell
On 16 February 2012 11:06, Kevin Wolf wrote: > What are all these m_ and mh_ prefixes for struct fields even about? > When I have an mbuf, I know perfectly well that it is one, and that > m_hdr is a header of it. That's the dead hand of Sixth Edition Unix and its C compiler that put all struct fi

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-16 Thread Kevin Wolf
Am 15.02.2012 19:55, schrieb Jan Kiszka: > On 2012-02-15 19:45, Michael S. Tsirkin wrote: >> Remove ugly macros for field names, >> change done by the following script: >> >> s#\bifq_prev\b#m_prev#g; >> s#\bifq_next\b#m_next#g; >> s#\bifs_prev\b#m_prevpkt#g; >> s#\bifs_next\b#m_nextpkt#g; >> s#\bif

Re: [Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-15 Thread Jan Kiszka
On 2012-02-15 19:45, Michael S. Tsirkin wrote: > Remove ugly macros for field names, > change done by the following script: > > s#\bifq_prev\b#m_prev#g; > s#\bifq_next\b#m_next#g; > s#\bifs_prev\b#m_prevpkt#g; > s#\bifs_next\b#m_nextpkt#g; > s#\bifq_so\b#m_so#g; > s#\bm_next\b#m_hdr.mh_next#g; > s

[Qemu-devel] [PATCH] slirp: kill ugly macros

2012-02-15 Thread Michael S. Tsirkin
Remove ugly macros for field names, change done by the following script: s#\bifq_prev\b#m_prev#g; s#\bifq_next\b#m_next#g; s#\bifs_prev\b#m_prevpkt#g; s#\bifs_next\b#m_nextpkt#g; s#\bifq_so\b#m_so#g; s#\bm_next\b#m_hdr.mh_next#g; s#\bm_prev\b#m_hdr.mh_prev#g; s#\bm_nextpkt\b#m_hdr.mh_nextpkt#g; s#