[Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-07-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this func

Re: [Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-14 Thread Samuel Thibault
Jan Kiszka, le Thu 12 Jun 2014 07:47:25 +0200, a écrit : > On 2014-06-11 10:55, Samuel Thibault wrote: > > Before this patch, if sosendto fails, udp_input is executed as if the > > packet was sent. This could cause memory leak. > > Cannot follow yet how this could leak (not saying I fully got what

Re: [Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-11 Thread Jan Kiszka
On 2014-06-11 10:55, Samuel Thibault wrote: > Before this patch, if sosendto fails, udp_input is executed as if the > packet was sent. This could cause memory leak. Cannot follow yet how this could leak (not saying I fully got what it should NOT leak - nasty code). Can you elaborate on the before/

[Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c