Re: [Qemu-devel] [PATCH] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Dunrong Huang
Thanks for your reply. 2012/7/6 Jan Kiszka : >> diff --git a/net/slirp.c b/net/slirp.c >> index 37b6ccf..a672cff 100644 >> --- a/net/slirp.c >> +++ b/net/slirp.c >> @@ -489,6 +489,20 @@ static int slirp_smb(SlirpState* s, const char >> *exported_dir, >> char smb_cmdline[128]; >> FILE *

Re: [Qemu-devel] [PATCH] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Jan Kiszka
Sorry for the late review. Two comments below. On 2012-07-03 15:13, Dunrong Huang wrote: > Users may pass the following parameters to qemu: > $ qemu-kvm -net nic -net user,smb= ... > $ qemu-kvm -net nic -net user,smb ... > $ qemu-kvm -net nic -net user,smb=bad_directory ... > > In the

[Qemu-devel] [PATCH] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-03 Thread Dunrong Huang
Users may pass the following parameters to qemu: $ qemu-kvm -net nic -net user,smb= ... $ qemu-kvm -net nic -net user,smb ... $ qemu-kvm -net nic -net user,smb=bad_directory ... In these cases, qemu started successfully while samba server failed to start. Users will confuse since samba