Re: [Qemu-devel] [PATCH] sii3112: Remove unneeded exit function

2018-03-06 Thread John Snow
On 03/06/2018 09:23 PM, David Gibson wrote: > On Wed, Mar 07, 2018 at 12:15:15AM +0100, BALATON Zoltan wrote: >> An exit function was mistakenly left here but it's not needed because >> the PCI bars are organised differently in this device. Calling this >> exit function during device_del was caus

Re: [Qemu-devel] [PATCH] sii3112: Remove unneeded exit function

2018-03-06 Thread David Gibson
On Wed, Mar 07, 2018 at 12:15:15AM +0100, BALATON Zoltan wrote: > An exit function was mistakenly left here but it's not needed because > the PCI bars are organised differently in this device. Calling this > exit function during device_del was causing an abort with > memory_region_del_subregion: `A

[Qemu-devel] [PATCH] sii3112: Remove unneeded exit function

2018-03-06 Thread BALATON Zoltan
An exit function was mistakenly left here but it's not needed because the PCI bars are organised differently in this device. Calling this exit function during device_del was causing an abort with memory_region_del_subregion: `Assertion subregion->container == mr' failed. Reported-by: Thomas Huth