Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-26 Thread Markus Armbruster
Liu Yuan writes: > On Wed, Feb 25, 2015 at 10:35:17AM +0100, Markus Armbruster wrote: >> Liu Yuan writes: >> >> > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: >> >> Liu Yuan writes: >> >> >> >> > From: Liu Yuan >> >> > >> >> > These functions mix up -1 and -errno in ret

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-25 Thread Liu Yuan
On Wed, Feb 25, 2015 at 10:35:17AM +0100, Markus Armbruster wrote: > Liu Yuan writes: > > > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: > >> Liu Yuan writes: > >> > >> > From: Liu Yuan > >> > > >> > These functions mix up -1 and -errno in return values and would might >

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-25 Thread Markus Armbruster
Liu Yuan writes: > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: >> Liu Yuan writes: >> >> > From: Liu Yuan >> > >> > These functions mix up -1 and -errno in return values and would might cause >> > trouble error handling in the call chain. >> > >> > This patch let them re

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-24 Thread Liu Yuan
On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: > Liu Yuan writes: > > > From: Liu Yuan > > > > These functions mix up -1 and -errno in return values and would might cause > > trouble error handling in the call chain. > > > > This patch let them return -errno and add some comm

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-18 Thread Markus Armbruster
Liu Yuan writes: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Reported-by: Markus Armbruster > Signed-off-by: Liu Yuan Did you revie

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-17 Thread Liu Yuan
On Mon, Feb 16, 2015 at 12:56:04PM +0100, Kevin Wolf wrote: > Am 13.02.2015 um 04:45 hat Liu Yuan geschrieben: > > From: Liu Yuan > > > > These functions mix up -1 and -errno in return values and would might cause > > trouble error handling in the call chain. > > > > This patch let them return -

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-16 Thread Kevin Wolf
Am 13.02.2015 um 04:45 hat Liu Yuan geschrieben: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Reported-by: Markus Armbruster > Signed

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 11:45:42AM +0800, Liu Yuan wrote: > From: Liu Yuan > > These functions mix up -1 and -errno in return values and would might cause > trouble error handling in the call chain. > > This patch let them return -errno and add some comments. > > Reported-by: Markus Armbruster

[Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
From: Liu Yuan These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Reported-by: Markus Armbruster Signed-off-by: Liu Yuan --- block/sheepdog.c | 11 +++ 1 file c