Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-10-02 Thread Remy NOEL
Hi On 8/30/18 1:28 PM, Gerd Hoffmann wrote: I'll take a look... Ping, any results? I'm wondering whenever we should just revert 93abfc88bd649de1933588bfc7175605331b3ea9. Retested hotplug with 93abfc88bd649de1933588bfc7175605331b3ea9 reverted. Works just fine with guest kernel loaded. Doesn'

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-30 Thread Gerd Hoffmann
Hi, > > Thanks for the feedback, after closer inspection, the secondary-vga > > refcount does, indeed, never reach 0. > > > > I noticed the bug was not present in v2.12.0 and had been visible since > > 93abfc88bd649de1933588bfc7175605331b3ea9 > > (https://lists.gnu.org/archive/html/qemu-devel/2

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-12 Thread Paolo Bonzini
On 11/08/2018 21:07, Remy NOEL wrote: > On 08/07/2018 05:09 PM, Dr. David Alan Gilbert wrote: > >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> On 7 August 2018 at 15:57, Dr. David Alan Gilbert >>> wrote: * Gerd Hoffmann (kra...@redhat.com) wrote: > On Fri, Jul 20, 2018 at 10:19

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-11 Thread Remy NOEL
On 08/07/2018 05:09 PM, Dr. David Alan Gilbert wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: On 7 August 2018 at 15:57, Dr. David Alan Gilbert wrote: * Gerd Hoffmann (kra...@redhat.com) wrote: On Fri, Jul 20, 2018 at 10:19:48AM +0200, remy.n...@blade-group.com wrote: From: "Remy

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-07 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 7 August 2018 at 15:57, Dr. David Alan Gilbert wrote: > > * Gerd Hoffmann (kra...@redhat.com) wrote: > >> On Fri, Jul 20, 2018 at 10:19:48AM +0200, remy.n...@blade-group.com wrote: > >> > From: "Remy Noel" > >> > > >> > When removing a second

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-07 Thread Peter Maydell
On 7 August 2018 at 15:57, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: >> On Fri, Jul 20, 2018 at 10:19:48AM +0200, remy.n...@blade-group.com wrote: >> > From: "Remy Noel" >> > >> > When removing a secondary-vga device and then adding it back (or adding >> > an othe

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-07 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > On Fri, Jul 20, 2018 at 10:19:48AM +0200, remy.n...@blade-group.com wrote: > > From: "Remy Noel" > > > > When removing a secondary-vga device and then adding it back (or adding > > an other one), qemu aborts with: > > "RAMBlock ":00:02.0/vga.vr

Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-08-07 Thread Gerd Hoffmann
On Fri, Jul 20, 2018 at 10:19:48AM +0200, remy.n...@blade-group.com wrote: > From: "Remy Noel" > > When removing a secondary-vga device and then adding it back (or adding > an other one), qemu aborts with: > "RAMBlock ":00:02.0/vga.vram" already registered, abort!". > > It is caused by t

[Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.

2018-07-20 Thread remy . noel
From: "Remy Noel" When removing a secondary-vga device and then adding it back (or adding an other one), qemu aborts with: "RAMBlock ":00:02.0/vga.vram" already registered, abort!". It is caused by the vram staying registered, preventing vga replugging. Signed-off-by: Remy Noel --- hw