Re: [Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Amit Shah
On (Wed) 21 Dec 2011 [11:37:57], Markus Armbruster wrote: > Replace > > error_report("DEVICE-NAME: MESSAGE"); > > by just > > error_report("MESSAGE"); > > in block device init functions. > > DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device > scsi-hd and scsi-cd, "virtio-

Re: [Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Stefan Hajnoczi
On Wed, Dec 21, 2011 at 11:37:57AM +0100, Markus Armbruster wrote: > Replace > > error_report("DEVICE-NAME: MESSAGE"); > > by just > > error_report("MESSAGE"); > > in block device init functions. > > DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device > scsi-hd and scsi-cd,

[Qemu-devel] [PATCH] scsi virtio-blk usb-msd: Clean up device init error messages

2011-12-21 Thread Markus Armbruster
Replace error_report("DEVICE-NAME: MESSAGE"); by just error_report("MESSAGE"); in block device init functions. DEVICE-NAME is bogus in some cases: it's "scsi-disk" for device scsi-hd and scsi-cd, "virtio-blk-pci" for virtio-blk-s390, and "usb-msd" for usb-storage. There is no real nee