Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-24 Thread Zheng Xiang
Ping? On 2019/2/15 11:17, Zheng Xiang wrote: > Hi Paolo, > > On 2019/2/15 2:07, Paolo Bonzini wrote: >> On 14/02/19 13:27, Xiang Zheng wrote: >>> There is a small window between the twice blk_is_available in >>> scsi_disk_emulate_command which would cause crash due to the later >>> assertion if t

Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-14 Thread Zheng Xiang
Hi Paolo, On 2019/2/15 2:07, Paolo Bonzini wrote: > On 14/02/19 13:27, Xiang Zheng wrote: >> There is a small window between the twice blk_is_available in >> scsi_disk_emulate_command which would cause crash due to the later >> assertion if the remote cdrom is detached in this window. >> >> So thi

Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-14 Thread Paolo Bonzini
On 14/02/19 13:27, Xiang Zheng wrote: > There is a small window between the twice blk_is_available in > scsi_disk_emulate_command which would cause crash due to the later > assertion if the remote cdrom is detached in this window. > > So this patch replaces assertions with return to avoid qemu cra

[Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-14 Thread Xiang Zheng
There is a small window between the twice blk_is_available in scsi_disk_emulate_command which would cause crash due to the later assertion if the remote cdrom is detached in this window. So this patch replaces assertions with return to avoid qemu crash. Signed-off-by: Xiang Zheng --- The qemu er