Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Pavel Hrdina
On 17.5.2013 14:15, Paolo Bonzini wrote: Il 17/05/2013 14:11, Pavel Hrdina ha scritto: On 17.5.2013 14:02, Paolo Bonzini wrote: Il 17/05/2013 13:57, Pavel Hrdina ha scritto: What happens when you suspend the QEMU machine to RAM? I believe the tray should remain open or, if closed, should rem

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 14:11, Pavel Hrdina ha scritto: > On 17.5.2013 14:02, Paolo Bonzini wrote: >> Il 17/05/2013 13:57, Pavel Hrdina ha scritto: What happens when you suspend the QEMU machine to RAM? I believe the tray should remain open or, if closed, should remain locked. Can you t

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Pavel Hrdina
On 17.5.2013 14:02, Paolo Bonzini wrote: Il 17/05/2013 13:57, Pavel Hrdina ha scritto: What happens when you suspend the QEMU machine to RAM? I believe the tray should remain open or, if closed, should remain locked. Can you try the same test on bare-metal (hint: boot to emergency mode to byp

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 13:57, Pavel Hrdina ha scritto: >> >> What happens when you suspend the QEMU machine to RAM? I believe the >> tray should remain open or, if closed, should remain locked. Can you >> try the same test on bare-metal (hint: boot to emergency mode to bypass >> anything that udev can do

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Pavel Hrdina
On 16.5.2013 18:11, Paolo Bonzini wrote: Il 16/05/2013 17:48, Pavel Hrdina ha scritto: From what I just tested it is the OS-independent HW behavior. Tested on desktop: 1. Turn off the computer. 2. Turn on the computer and after few second open the CD-ROM tray before any OS system is loaded an

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-16 Thread Paolo Bonzini
Il 16/05/2013 17:48, Pavel Hrdina ha scritto: > > From what I just tested it is the OS-independent HW behavior. > > Tested on desktop: > 1. Turn off the computer. > 2. Turn on the computer and after few second open the CD-ROM tray before > any OS system is loaded and holding the power button turn

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-16 Thread Pavel Hrdina
On 16.5.2013 17:42, Eric Blake wrote: On 05/16/2013 09:34 AM, Pavel Hrdina wrote: Tray statuses should be also reseted. Some guests may lock the tray s/reseted/reset/ and after reset before any kernel is loaded the tray should be unlocked. Also if you reset the real computer the tray is clo

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-16 Thread Eric Blake
On 05/16/2013 09:34 AM, Pavel Hrdina wrote: > Tray statuses should be also reseted. Some guests may lock the tray s/reseted/reset/ > and after reset before any kernel is loaded the tray should be unlocked. > > Also if you reset the real computer the tray is closed. We should > do the same in qem

[Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-16 Thread Pavel Hrdina
Tray statuses should be also reseted. Some guests may lock the tray and after reset before any kernel is loaded the tray should be unlocked. Also if you reset the real computer the tray is closed. We should do the same in qemu. This fix is already commited for IDE CD. Check the commit a7f3d65b65b