Re: [Qemu-devel] [PATCH] scsi: pvscsi: limit process IO loop to maximum page count

2016-09-13 Thread P J P
+-- On Tue, 13 Sep 2016, Dmitry Fleytman wrote --+ | > A guest user could set the 'ready_ptr' and 'PVSCSIRingInfo *mgr' parameter | > in 'pvscsi_ring_pop_req_descr', such that it always returns true. | | I see. The problematic code is if (ready_ptr != mgr->consumed_ptr) {…} | | mgr->consumed_pt

Re: [Qemu-devel] [PATCH] scsi: pvscsi: limit process IO loop to maximum page count

2016-09-13 Thread Dmitry Fleytman
> On 13 Sep 2016, at 13:48 PM, P J P wrote: > > Hello Dmitry, > > +-- On Tue, 13 Sep 2016, Dmitry Fleytman wrote --+ > | > On 13 Sep 2016, at 10:00 AM, P J P wrote: > | > > | > +-- On Wed, 7 Sep 2016, P J P wrote --+ > | > | From: Prasad J Pandit > | > | > | > | Vmware Paravirtual SCSI emu

Re: [Qemu-devel] [PATCH] scsi: pvscsi: limit process IO loop to maximum page count

2016-09-13 Thread P J P
Hello Dmitry, +-- On Tue, 13 Sep 2016, Dmitry Fleytman wrote --+ | > On 13 Sep 2016, at 10:00 AM, P J P wrote: | > | > +-- On Wed, 7 Sep 2016, P J P wrote --+ | > | From: Prasad J Pandit | > | | > | Vmware Paravirtual SCSI emulator while processing IO requests | > | could run into an infinit

Re: [Qemu-devel] [PATCH] scsi: pvscsi: limit process IO loop to maximum page count

2016-09-13 Thread Dmitry Fleytman
Hello Prasad, Please see my questions inline. > On 13 Sep 2016, at 10:00 AM, P J P wrote: > > +-- On Wed, 7 Sep 2016, P J P wrote --+ > | From: Prasad J Pandit > | > | Vmware Paravirtual SCSI emulator while processing IO requests > | could run into an infinite loop if 'pvscsi_ring_pop_req_des

Re: [Qemu-devel] [PATCH] scsi: pvscsi: limit process IO loop to maximum page count

2016-09-13 Thread P J P
+-- On Wed, 7 Sep 2016, P J P wrote --+ | From: Prasad J Pandit | | Vmware Paravirtual SCSI emulator while processing IO requests | could run into an infinite loop if 'pvscsi_ring_pop_req_descr' | always returned positive value. Limit IO loop to the maximum | page count. | | Reported-by: Li Qian

[Qemu-devel] [PATCH] scsi: pvscsi: limit process IO loop to maximum page count

2016-09-06 Thread P J P
From: Prasad J Pandit Vmware Paravirtual SCSI emulator while processing IO requests could run into an infinite loop if 'pvscsi_ring_pop_req_descr' always returned positive value. Limit IO loop to the maximum page count. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/vmw_pvsc