On Thu, 12/17 09:41, Paolo Bonzini wrote:
>
>
> On 17/12/2015 02:15, Fam Zheng wrote:
> >> > if (notifier) {
> >> > notifier_list_add(&req->cancel_notifiers, notifier);
> >> > }
> >> > -if (req->io_canceled) {
> >> > -return;
> >> > -}
> >> > scsi_req_ref(r
On 17/12/2015 02:15, Fam Zheng wrote:
>> > if (notifier) {
>> > notifier_list_add(&req->cancel_notifiers, notifier);
>> > }
>> > -if (req->io_canceled) {
>> > -return;
>> > -}
>> > scsi_req_ref(req);
>> > scsi_req_dequeue(req);
>> > req->io_cancel
On Wed, 12/16 19:33, Paolo Bonzini wrote:
> This was found by code inspection. If the request is cancelled twice,
> the notifier is never called on the second cancellation request,
> and hence for example a TMF might never finish.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/scsi/scsi-bus.c | 3
This was found by code inspection. If the request is cancelled twice,
the notifier is never called on the second cancellation request,
and hence for example a TMF might never finish.
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-bus.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/scs
