Re: [Qemu-devel] [PATCH] scripts: use git archive in archive-source

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190130065530.6371-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] scripts: use git archive in archive-source Type: series Message-id: 20190130065530.6371

Re: [Qemu-devel] [PATCH] scripts: use git archive in archive-source

2019-01-31 Thread Daniel P . Berrangé
On Thu, Jan 31, 2019 at 08:41:43AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +git archive --format tar $HEAD > "$tar_file" > > > +test $? -ne 0 && error "failed to archive qemu" > > > for sm in $submodules; do > > > -git submodule update --init $sm > > > -test $? -ne 0 && error "failed

Re: [Qemu-devel] [PATCH] scripts: use git archive in archive-source

2019-01-30 Thread Gerd Hoffmann
Hi, > > +git archive --format tar $HEAD > "$tar_file" > > +test $? -ne 0 && error "failed to archive qemu" > > for sm in $submodules; do > > -git submodule update --init $sm > > -test $? -ne 0 && error "failed to init submodule $sm" > > + git submodule update --init "$sm" > > The cur

Re: [Qemu-devel] [PATCH] scripts: use git archive in archive-source

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 07:55:30AM +0100, Gerd Hoffmann wrote: > Use git archive to create tarballs of qemu and submodules instead of > cloning the repository and the submodules. This is a order of magnitude > faster because it doesn't fetch the submodules from the internet each > time the script

[Qemu-devel] [PATCH] scripts: use git archive in archive-source

2019-01-29 Thread Gerd Hoffmann
Use git archive to create tarballs of qemu and submodules instead of cloning the repository and the submodules. This is a order of magnitude faster because it doesn't fetch the submodules from the internet each time the script runs. Signed-off-by: Gerd Hoffmann --- scripts/archive-source.sh | 4