Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: fix false error of externs checking.

2017-10-10 Thread Peter Maydell
On 10 October 2017 at 08:54, Jiang Biao wrote: > When adding a function declaration in a .c file without extern > keywork decoration, checkpatch.pl will report *externs should be > avoided in .c files* false error. This patch fixes the bug. I don't think this is a bug. "extern int foo(void);" and

[Qemu-devel] [PATCH] scripts/checkpatch.pl: fix false error of externs checking.

2017-10-10 Thread Jiang Biao
When adding a function declaration in a .c file without extern keywork decoration, checkpatch.pl will report *externs should be avoided in .c files* false error. This patch fixes the bug. Signed-off-by: Jiang Biao --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d