Re: [Qemu-devel] [PATCH] s390x: Fix stoc direction

2015-05-05 Thread Richard Henderson
On 04/14/2015 06:45 PM, Alexander Graf wrote: > The store conditional instruction wants to store when the condition > is fulfilled, so we should branch out when it's not true. > > The code today branches out when the condition is true, clearly > reversing the logic. Fix it up by negating the condi

[Qemu-devel] [PATCH] s390x: Fix stoc direction

2015-04-14 Thread Alexander Graf
The store conditional instruction wants to store when the condition is fulfilled, so we should branch out when it's not true. The code today branches out when the condition is true, clearly reversing the logic. Fix it up by negating the condition. Signed-off-by: Alexander Graf --- target-s390x/