Re: [Qemu-devel] [PATCH] s390x/vfio-ap: report correct error

2018-10-16 Thread Cornelia Huck
On Tue, 16 Oct 2018 13:58:17 +0200 Cornelia Huck wrote: > If ioctl(..., VFIO_DEVICE_RESET) fails, we want to report errno > instead of ret (which is always -1 on error). > > Fixes Coverity issue CID 1396176. > > Reported-by: Peter Maydell > Signed-off-by: Cornelia Huck > --- > hw/vfio/ap.c |

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: report correct error

2018-10-16 Thread Tony Krowiak
On 10/16/2018 07:58 AM, Cornelia Huck wrote: If ioctl(..., VFIO_DEVICE_RESET) fails, we want to report errno instead of ret (which is always -1 on error). Fixes Coverity issue CID 1396176. Reported-by: Peter Maydell Signed-off-by: Cornelia Huck --- hw/vfio/ap.c | 2 +- 1 file changed, 1 in

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: report correct error

2018-10-16 Thread Christian Borntraeger
On 10/16/2018 01:58 PM, Cornelia Huck wrote: > If ioctl(..., VFIO_DEVICE_RESET) fails, we want to report errno > instead of ret (which is always -1 on error). > > Fixes Coverity issue CID 1396176. > > Reported-by: Peter Maydell > Signed-off-by: Cornelia Huck makes sense Reviewed-by: Christ

[Qemu-devel] [PATCH] s390x/vfio-ap: report correct error

2018-10-16 Thread Cornelia Huck
If ioctl(..., VFIO_DEVICE_RESET) fails, we want to report errno instead of ret (which is always -1 on error). Fixes Coverity issue CID 1396176. Reported-by: Peter Maydell Signed-off-by: Cornelia Huck --- hw/vfio/ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/a