Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

2016-11-29 Thread Paolo Bonzini
On 29/11/2016 18:16, Stefan Hajnoczi wrote: > FWIW I applied the pull request with the broken -r fix. Then I applied > this patch on top (and added a note to the commit description explaining > this was a refinement). I've also merged your newest pull request for > -rc2. Ok, that pull request

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 05:57:04PM +0100, Paolo Bonzini wrote: > > > On 29/11/2016 17:22, Stefan Hajnoczi wrote: > > On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: > >> Building qemu fails in distributions where gcc enables PIE by default > >> (e.g. Debian unstable) with: > >> > >

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

2016-11-29 Thread Paolo Bonzini
On 29/11/2016 17:22, Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: >> Building qemu fails in distributions where gcc enables PIE by default >> (e.g. Debian unstable) with: >> >> /usr/bin/ld: -r and -pie may not be used together >> >> You have to use -r in

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: > Building qemu fails in distributions where gcc enables PIE by default > (e.g. Debian unstable) with: > > /usr/bin/ld: -r and -pie may not be used together > > You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the lin

[Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

2016-11-29 Thread Paolo Bonzini
Building qemu fails in distributions where gcc enables PIE by default (e.g. Debian unstable) with: /usr/bin/ld: -r and -pie may not be used together You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the linker when PIE is enabled and a relocatable object is passed. However, clang