Re: [Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets

2012-06-27 Thread Anthony Liguori
On 05/17/2012 12:25 AM, Jason Wang wrote: Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible crash during initialization of linux driver by checking the operating mode.This seems too strict as: - the real card could still work in mode other than normal - some buggy driver who d

Re: [Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets

2012-06-27 Thread Avi Kivity
On 05/17/2012 08:25 AM, Jason Wang wrote: > Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible > crash during initialization of linux driver by checking the operating > mode.This seems too strict as: > > - the real card could still work in mode other than normal > - some buggy dr

Re: [Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets

2012-05-18 Thread Fernando Luis Vazquez Cao
Hi Anthony, Michael, While at it, could you pick up the attached patch too? It has already been acked by Igor Kovalenko. Thanks, Fernando Subject: [PATCH] rtl8139: honor RxOverflow flag in can_receive method From: Fernando Luis Vazquez Cao Some drivers (Linux' 8139too among them) rely on the

[Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets

2012-05-16 Thread Jason Wang
Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible crash during initialization of linux driver by checking the operating mode.This seems too strict as: - the real card could still work in mode other than normal - some buggy driver who does not set correct opmode after eeprom acc