Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-28 Thread Palmer Dabbelt
On Tue, 27 Nov 2018 17:46:04 PST (-0800), maozhon...@cmss.chinamobile.com wrote: Hi, Palmer On 11/28/18 8:34 AM, Palmer Dabbelt wrote: On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote: On 11/26/18 4:20 AM, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi ---   target/riscv/cpu

Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-27 Thread maozy
Hi, Palmer On 11/28/18 8:34 AM, Palmer Dabbelt wrote: On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote: On 11/26/18 4:20 AM, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi ---   target/riscv/cpu.c | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bast

Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-27 Thread Palmer Dabbelt
On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote: On 11/26/18 4:20 AM, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bastian Koppelmann Shouldn't we also use device_class_set

Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-26 Thread Alistair Francis
On Sun, Nov 25, 2018 at 7:21 PM Mao Zhongyi wrote: > > Signed-off-by: Mao Zhongyi Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index a025a0a3ba..5e8a2cb

Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-26 Thread Bastian Koppelmann
On 11/26/18 4:20 AM, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Bastian Koppelmann Cheers, Bastian

[Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

2018-11-25 Thread Mao Zhongyi
Signed-off-by: Mao Zhongyi --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index a025a0a3ba..5e8a2cb2ba 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -330,8 +330,8 @@ static void riscv_cpu_class_i