Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile

2018-11-14 Thread Alex Bennée
Peter Xu writes: > We've fixed it before like 38bb54f323 ("replication: Make > --disable-replication compile again", 2017-04-28) but it's failing > again. So fix it again. If replication builds by default and you want to defend it not building then it would probably be worth adding it to the

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile

2018-11-14 Thread Peter Xu
On Wed, Nov 14, 2018 at 10:37:23AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We've fixed it before like 38bb54f323 ("replication: Make > > --disable-replication compile again", 2017-04-28) but it's failing > > again. So fix it again. > > > > There could be e

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile

2018-11-14 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > We've fixed it before like 38bb54f323 ("replication: Make > --disable-replication compile again", 2017-04-28) but it's failing > again. So fix it again. > > There could be even cleaner way to fix this but current way is the > simplest. Let's start from sim

[Qemu-devel] [PATCH] replication: Make --disable-replication compile

2018-11-13 Thread Peter Xu
We've fixed it before like 38bb54f323 ("replication: Make --disable-replication compile again", 2017-04-28) but it's failing again. So fix it again. There could be even cleaner way to fix this but current way is the simplest. Let's start from simple. CC: zhanghailiang CC: Juan Quintela CC: "D

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile again

2017-04-28 Thread Stefan Hajnoczi
On Thu, Apr 27, 2017 at 03:00:53PM +0200, Markus Armbruster wrote: > Broken in commit daa33c5. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster > --- > migration/colo.c | 12 > monitor.c| 5 + > 2 files changed, 17 insertions(+) Thanks, applied to my s

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile again

2017-04-27 Thread Markus Armbruster
Zhang Chen writes: > On 04/27/2017 09:00 PM, Markus Armbruster wrote: >> Broken in commit daa33c5. >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Markus Armbruster > > About this bug I remember have discussed with paolo. > > https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg01326.h

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile again

2017-04-27 Thread Zhang Chen
On 04/27/2017 09:00 PM, Markus Armbruster wrote: Broken in commit daa33c5. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster About this bug I remember have discussed with paolo. https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg01326.html And about this patch content.

Re: [Qemu-devel] [PATCH] replication: Make --disable-replication compile again

2017-04-27 Thread Eric Blake
On 04/27/2017 08:00 AM, Markus Armbruster wrote: > Broken in commit daa33c5. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster > --- > migration/colo.c | 12 > monitor.c| 5 + > 2 files changed, 17 insertions(+) Reviewed-by: Eric Blake -- Eric Blake,

[Qemu-devel] [PATCH] replication: Make --disable-replication compile again

2017-04-27 Thread Markus Armbruster
Broken in commit daa33c5. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- migration/colo.c | 12 monitor.c| 5 + 2 files changed, 17 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index c19eb3f..963c802 100644 --- a/migration/colo.c +++