Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-10 Thread Paolo Bonzini
On 11/09/2011 05:22 PM, Eduardo Habkost wrote: The bug was 100% reproducible on the machine I was testing, previously, and after this commit it didn't happen anymore. I double-checked by re-testing this commit (47113ab6), and the previous one (f67ab77a) twice, after bisecting. (If anybody has so

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-09 Thread Eduardo Habkost
On Tue, Nov 08, 2011 at 11:24:30AM -0600, Anthony Liguori wrote: > On 11/03/2011 09:45 PM, Wen Congyang wrote: > >We disable vm_clock when pausing all vcpus, but we forget to > >reenable it when resuming all vcpus. It will cause that the > >guest can not be rebooted. > > > >Signed-off-by: Wen Congy

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-08 Thread Anthony Liguori
On 11/03/2011 09:45 PM, Wen Congyang wrote: We disable vm_clock when pausing all vcpus, but we forget to reenable it when resuming all vcpus. It will cause that the guest can not be rebooted. Signed-off-by: Wen Congyang Applied. Thanks. Regards, Anthony Liguori --- cpus.c |1 + 1

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-06 Thread Zhi Yong Wu
On Fri, Nov 4, 2011 at 2:26 PM, Wen Congyang wrote: > At 11/04/2011 10:48 AM, Zhi Yong Wu Write: >> On Fri, Nov 4, 2011 at 10:45 AM, Wen Congyang wrote: >>> >>> We disable vm_clock when pausing all vcpus, but we forget to >>> reenable it when resuming all vcpus. It will cause that the >>> guest c

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-04 Thread Zhi Yong Wu
On Fri, Nov 4, 2011 at 2:26 PM, Wen Congyang wrote: > At 11/04/2011 10:48 AM, Zhi Yong Wu Write: >> On Fri, Nov 4, 2011 at 10:45 AM, Wen Congyang wrote: >>> >>> We disable vm_clock when pausing all vcpus, but we forget to >>> reenable it when resuming all vcpus. It will cause that the >>> guest c

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 03:45 AM, Wen Congyang wrote: We disable vm_clock when pausing all vcpus, but we forget to reenable it when resuming all vcpus. It will cause that the guest can not be rebooted. Signed-off-by: Wen Congyang --- cpus.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) d

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-03 Thread Wen Congyang
At 11/04/2011 10:48 AM, Zhi Yong Wu Write: > On Fri, Nov 4, 2011 at 10:45 AM, Wen Congyang wrote: >> >> We disable vm_clock when pausing all vcpus, but we forget to >> reenable it when resuming all vcpus. It will cause that the >> guest can not be rebooted. > Actually i also met this issue when re

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-03 Thread Zhi Yong Wu
On Fri, Nov 4, 2011 at 10:45 AM, Wen Congyang wrote: > > We disable vm_clock when pausing all vcpus, but we forget to > reenable it when resuming all vcpus. It will cause that the > guest can not be rebooted. Actually i also met this issue when rebooting the guest. When the guest is rebooted, it w

[Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-03 Thread Wen Congyang
We disable vm_clock when pausing all vcpus, but we forget to reenable it when resuming all vcpus. It will cause that the guest can not be rebooted. Signed-off-by: Wen Congyang --- cpus.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 6aff425..8253