Re: [Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-23 Thread Gonglei
On 2015/6/23 17:20, Markus Armbruster wrote: > Markus Armbruster writes: > >> writes: >> >>> From: Gonglei >>> >>> Variable "r" going out of scope leaks the storage >>> it points to in line 3268. >>> >>> Signed-off-by: Gonglei >>> --- >>> migration/rdma.c | 3 ++- >>> 1 file changed, 2 insert

Re: [Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-23 Thread Markus Armbruster
Markus Armbruster writes: > writes: > >> From: Gonglei >> >> Variable "r" going out of scope leaks the storage >> it points to in line 3268. >> >> Signed-off-by: Gonglei >> --- >> migration/rdma.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/migration/rdma.c b

Re: [Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-23 Thread Paolo Bonzini
On 23/06/2015 03:02, arei.gong...@huawei.com wrote: > From: Gonglei > > Variable "r" going out of scope leaks the storage > it points to in line 3268. > > Signed-off-by: Gonglei > --- > migration/rdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration/rdm

Re: [Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-23 Thread Markus Armbruster
writes: > From: Gonglei > > Variable "r" going out of scope leaks the storage > it points to in line 3268. > > Signed-off-by: Gonglei > --- > migration/rdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index cf5de7e..de80860

Re: [Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-22 Thread Amit Shah
On (Tue) 23 Jun 2015 [09:02:28], arei.gong...@huawei.com wrote: > From: Gonglei > > Variable "r" going out of scope leaks the storage > it points to in line 3268. Interestingly Dave posted a different patch for the same issue. I prefer this approach. Reviewed-by: Amit Shah Am

[Qemu-devel] [PATCH] rdma: fix memory leak

2015-06-22 Thread arei.gonglei
From: Gonglei Variable "r" going out of scope leaks the storage it points to in line 3268. Signed-off-by: Gonglei --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index cf5de7e..de80860 100644 --- a/migration/rdma.c