Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-07 Thread Kevin Wolf
Am 07.09.2010 04:04, schrieb Christoph Hellwig: > On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote: >> >> On 06.09.2010, at 17:06, Bernhard Kohl wrote: >> >>> From: Bernhard Kohl >>> >>> Allow symbolic links which point to /dev/sgX devices. >> >> Couldn't you send an SG_IO test ioctl

Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-07 Thread Alexander Graf
On 07.09.2010, at 11:40, Bernhard Kohl wrote: > Am 07.09.2010 04:04, schrieb ext Christoph Hellwig: >> On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote: >> >>> On 06.09.2010, at 17:06, Bernhard Kohl wrote: >>> >>> From: Bernhard Kohl Allow symbolic links whi

Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-07 Thread Bernhard Kohl
Am 07.09.2010 04:04, schrieb ext Christoph Hellwig: On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote: On 06.09.2010, at 17:06, Bernhard Kohl wrote: From: Bernhard Kohl Allow symbolic links which point to /dev/sgX devices. Couldn't you send an SG_IO test ioctl

Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-06 Thread Christoph Hellwig
On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote: > > On 06.09.2010, at 17:06, Bernhard Kohl wrote: > > > From: Bernhard Kohl > > > > Allow symbolic links which point to /dev/sgX devices. > > Couldn't you send an SG_IO test ioctl over and see if it works? I really > dislike the

Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-06 Thread Alexander Graf
On 06.09.2010, at 17:06, Bernhard Kohl wrote: > From: Bernhard Kohl > > Allow symbolic links which point to /dev/sgX devices. Couldn't you send an SG_IO test ioctl over and see if it works? I really dislike the whole file name magic matching. Alex

[Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices

2010-09-06 Thread Bernhard Kohl
From: Bernhard Kohl Allow symbolic links which point to /dev/sgX devices. Signed-off-by: Bernhard Kohl --- block/raw-posix.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 72fb8ce..4544a57 100644 --- a/block/raw-pos