Re: [Qemu-devel] [PATCH] qxl: switch to constants within BUILD_BUG_ON

2017-01-25 Thread Eric Blake
On 01/25/2017 03:52 PM, Michael S. Tsirkin wrote: > We are switching BUILD_BUG_ON to verify that it's parameter is a > compile-time constant, and it turns out that some gcc versions > (specifically gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) are > not smart enough to figure it out for expre

[Qemu-devel] [PATCH] qxl: switch to constants within BUILD_BUG_ON

2017-01-25 Thread Michael S. Tsirkin
We are switching BUILD_BUG_ON to verify that it's parameter is a compile-time constant, and it turns out that some gcc versions (specifically gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) are not smart enough to figure it out for expressions involving local variables. This is harmless but mea