Re: [Qemu-devel] [PATCH] qtest: add rtc periodic timer test

2017-05-26 Thread Xiao Guangrong
On 05/26/2017 07:03 PM, Paolo Bonzini wrote: Can you send v2 that integrates this in rtc-test.c? Really smart, have posted the v2 out, please review. Thank you, Paolo!

Re: [Qemu-devel] [PATCH] qtest: add rtc periodic timer test

2017-05-26 Thread Paolo Bonzini
On 26/05/2017 05:21, Xiao Guangrong wrote: > On 05/26/2017 12:03 AM, Paolo Bonzini wrote: >> On 25/05/2017 05:19, guangrong.x...@gmail.com wrote: >> I'm not sure I understand. Why would clock_step(1000) not be a good >> replacement for nsleep(1000)? > > We can not. As we use the real time to co

Re: [Qemu-devel] [PATCH] qtest: add rtc periodic timer test

2017-05-25 Thread Xiao Guangrong
On 05/26/2017 12:03 AM, Paolo Bonzini wrote: On 25/05/2017 05:19, guangrong.x...@gmail.com wrote: Note: as qemu needs a precise timer to drive its rtc timer callbacks, that means clock=vm is not suitable for us as it's driven by icount for qtest, so that we use clock=host instead, it is why

Re: [Qemu-devel] [PATCH] qtest: add rtc periodic timer test

2017-05-25 Thread Paolo Bonzini
On 25/05/2017 05:19, guangrong.x...@gmail.com wrote: > > Note: as qemu needs a precise timer to drive its rtc timer callbacks, > that means clock=vm is not suitable for us as it's driven by icount > for qtest, so that we use clock=host instead, it is why we put the > periodic timer test separate

[Qemu-devel] [PATCH] qtest: add rtc periodic timer test

2017-05-24 Thread guangrong . xiao
From: Xiao Guangrong It tests the accuracy of rtc periodic timer which is recently improved & fixed by: mc146818rtc: precisely count the clock for periodic timer (commit id has not been decided yet) Note: as qemu needs a precise timer to drive its rtc timer callbacks, that means clock=vm i