Re: [Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-31 Thread Paolo Bonzini
On 31/05/2018 05:45, Alexey Kardashevskiy wrote: > Well, this is correct indeed for the normal case when the result is used > for internal business but for my task (show the owner of an MR or at least > give a clue what to grep for) it will discard a partial path. > > I guess I could print a typen

Re: [Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-30 Thread Alexey Kardashevskiy
On 31/5/18 2:23 am, Paolo Bonzini wrote: > Mostly a rewrite, in order to keep the loop simple. > > Signed-off-by: Paolo Bonzini > --- > qom/object.c | 29 - > 1 file changed, 16 insertions(+), 13 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 0fc97

Re: [Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 01:23 PM, Paolo Bonzini wrote: > Mostly a rewrite, in order to keep the loop simple. Thus easier to review using "git difftool -y -x sdiff" (or whichever tool you prefer, such meld). "git format-patch" doesn't provide a way to generate side-by-side diffs applicable. > > Signed-off

[Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-30 Thread Paolo Bonzini
Mostly a rewrite, in order to keep the loop simple. Signed-off-by: Paolo Bonzini --- qom/object.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/qom/object.c b/qom/object.c index 0fc972030e..4f30431ae3 100644 --- a/qom/object.c +++ b/qom/objec