Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-21 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 07:16:31PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > When debugging QEMU it is often useful to put a breakpoint on the > > error_setg_internal method impl. > > > > Unfortunately the object_property_add / object_class_property_add > > methods call o

Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find / object_class_property_find methods > to check if a property

Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 09:45:23AM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Nov 19, 2018 at 5:59 PM Daniel P. Berrangé > wrote: > > > > When debugging QEMU it is often useful to put a breakpoint on the > > error_setg_internal method impl. > > > > Unfortunately the object_property_add / o

Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-19 Thread Marc-André Lureau
Hi On Mon, Nov 19, 2018 at 5:59 PM Daniel P. Berrangé wrote: > > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find / object_class_property_f

[Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-19 Thread Daniel P . Berrangé
When debugging QEMU it is often useful to put a breakpoint on the error_setg_internal method impl. Unfortunately the object_property_add / object_class_property_add methods call object_property_find / object_class_property_find methods to check if a property exists already before adding the new pr