Re: [Qemu-devel] [PATCH] qom: add style guide

2012-08-14 Thread Jens Freimann
On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > docs/qom-style-guide.md | 489 > +++ > 1 files changed, 489 insertions(+), 0 deletions(-) > create mode 100644 docs/qom-style-guide.md > > diff

Re: [Qemu-devel] [PATCH] qom: add style guide

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 03:57:41PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote: > >> +typedef struct MyType MyType; > >> + > >> +struct MyType > >> +{ > > > > This seems to violate our style:sho

Re: [Qemu-devel] [PATCH] qom: add style guide

2012-08-13 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote: >> +typedef struct MyType MyType; >> + >> +struct MyType >> +{ > > This seems to violate our style:should be > >> +struct MyType { That's a bug in CODING_STYLE. Coding style only

Re: [Qemu-devel] [PATCH] qom: add style guide

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 01:46:46PM -0500, Anthony Liguori wrote: > +typedef struct MyType MyType; > + > +struct MyType > +{ This seems to violate our style:should be > +struct MyType { > +Object parent_obj; > + > +/*< private >*/ > +int foo; > +

[Qemu-devel] [PATCH] qom: add style guide

2012-08-13 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- docs/qom-style-guide.md | 489 +++ 1 files changed, 489 insertions(+), 0 deletions(-) create mode 100644 docs/qom-style-guide.md diff --git a/docs/qom-style-guide.md b/docs/qom-style-guide.md new file mode 100644 in