Re: [Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Igor Mammedov
On Tue, 29 Aug 2017 19:03:37 -0300 Eduardo Habkost wrote: > The errp argument is ignored by all implementations of the > method, and user_creatable_del() would break if any > implementation set an error (because it calls error_setg(errp) if > the function returns false). Remove the unused parame

Re: [Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Gonglei (Arei)
> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Wednesday, August 30, 2017 6:04 AM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei); Paolo Bonzini; Igor Mammedov; Andreas Färber; Lin Ma > Subject: [PATCH] qom: Remove unused errp parameter from can_be_delet

[Qemu-devel] [PATCH] qom: Remove unused errp parameter from can_be_deleted()

2017-08-29 Thread Eduardo Habkost
The errp argument is ignored by all implementations of the method, and user_creatable_del() would break if any implementation set an error (because it calls error_setg(errp) if the function returns false). Remove the unused parameter. Signed-off-by: Eduardo Habkost --- include/qom/object_interf