Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-03-11 Thread Edgar E. Iglesias
On Wed, Mar 12, 2014 at 12:03:19AM +, Peter Maydell wrote: > On 11 March 2014 23:58, Andreas Färber wrote: > > Am 20.02.2014 16:58, schrieb Peter Maydell: > >> On 16 February 2014 02:07, Edgar E. Iglesias > >> wrote: > >>> On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: >

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-03-11 Thread Peter Maydell
On 11 March 2014 23:58, Andreas Färber wrote: > Am 20.02.2014 16:58, schrieb Peter Maydell: >> On 16 February 2014 02:07, Edgar E. Iglesias >> wrote: >>> On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: On 13 February 2014 05:07, wrote: > From: "Edgar E. Iglesias" >

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-03-11 Thread Andreas Färber
Am 20.02.2014 16:58, schrieb Peter Maydell: > On 16 February 2014 02:07, Edgar E. Iglesias wrote: >> On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: >>> On 13 February 2014 05:07, wrote: From: "Edgar E. Iglesias" cpu->exit_request is part of the execution environme

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-20 Thread Peter Maydell
On 20 February 2014 23:26, Edgar E. Iglesias wrote: > On Thu, Feb 20, 2014 at 03:58:15PM +, Peter Maydell wrote: >> However, doesn't this also apply to interrupt_request ? >> If we have a pending asserted interrupt on the CPU >> (ie the IRQ line into the chip is being held high) >> this should

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-20 Thread Edgar E. Iglesias
On Thu, Feb 20, 2014 at 03:58:15PM +, Peter Maydell wrote: > On 16 February 2014 02:07, Edgar E. Iglesias wrote: > > On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: > >> On 13 February 2014 05:07, wrote: > >> > From: "Edgar E. Iglesias" > >> > > >> > cpu->exit_request is part

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-20 Thread Peter Maydell
On 20 February 2014 16:15, Andreas Färber wrote: > Am 20.02.2014 16:58, schrieb Peter Maydell: >> On 16 February 2014 02:07, Edgar E. Iglesias >> wrote: >>> Seeing this in TCG. The CPU gets signaled by the IO thread while the >>> CPU is resetting itself. If the CPU looses the race, it clears its

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-20 Thread Andreas Färber
Am 20.02.2014 16:58, schrieb Peter Maydell: > On 16 February 2014 02:07, Edgar E. Iglesias wrote: >> On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: >>> On 13 February 2014 05:07, wrote: From: "Edgar E. Iglesias" cpu->exit_request is part of the execution environme

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-20 Thread Peter Maydell
On 16 February 2014 02:07, Edgar E. Iglesias wrote: > On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: >> On 13 February 2014 05:07, wrote: >> > From: "Edgar E. Iglesias" >> > >> > cpu->exit_request is part of the execution environment and should >> > not be cleared when a CPU res

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-15 Thread Edgar E. Iglesias
On Sat, Feb 15, 2014 at 03:42:56PM +, Peter Maydell wrote: > On 13 February 2014 05:07, wrote: > > From: "Edgar E. Iglesias" > > > > cpu->exit_request is part of the execution environment and should > > not be cleared when a CPU resets. > > > > Otherwise, we might deadlock QEMU if a CPU rese

Re: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-15 Thread Peter Maydell
On 13 February 2014 05:07, wrote: > From: "Edgar E. Iglesias" > > cpu->exit_request is part of the execution environment and should > not be cleared when a CPU resets. > > Otherwise, we might deadlock QEMU if a CPU resets while there is > I/O going on. > > Signed-off-by: Edgar E. Iglesias > ---

[Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state

2014-02-12 Thread edgar . iglesias
From: "Edgar E. Iglesias" cpu->exit_request is part of the execution environment and should not be cleared when a CPU resets. Otherwise, we might deadlock QEMU if a CPU resets while there is I/O going on. Signed-off-by: Edgar E. Iglesias --- qom/cpu.c | 1 - 1 file changed, 1 deletion(-) dif